Back in the day I actually liked the huge original controllers the first X-Box came with. Everyone else hated them, but they really just fit my hands great. The little ones they replaced them with gave me hand cramps.
Nowadays my only controller is a T4 Kaleid thing, that has zero stick drift because the thumbsticks have magnetic Hall Effect bearings, or something. So far it's lasted longer than any of my previous controllers, but then I don't play games all that much either. For $50 it isn't bad though.